Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix executor metrics in release mode #3087

Merged
merged 1 commit into from
Jun 9, 2022
Merged

fix(ci): fix executor metrics in release mode #3087

merged 1 commit into from
Jun 9, 2022

Conversation

MingjiHan99
Copy link
Contributor

@MingjiHan99 MingjiHan99 commented Jun 9, 2022

What's changed and what's your intention?

Fix executor metrics in release mode

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@MingjiHan99 MingjiHan99 requested a review from skyzh June 9, 2022 02:14
@github-actions github-actions bot added the type/fix Bug fix label Jun 9, 2022
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please also test it locally? risedev configure can help you build and test using release mode.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3087 (1bc82ff) into main (aae3f9c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3087   +/-   ##
=======================================
  Coverage   73.40%   73.40%           
=======================================
  Files         734      734           
  Lines       99959    99959           
=======================================
  Hits        73376    73376           
  Misses      26583    26583           
Flag Coverage Δ
rust 73.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/debug.rs 0.00% <0.00%> (ø)
src/stream/src/executor/debug/trace.rs 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@MingjiHan99 MingjiHan99 merged commit 77e07f0 into main Jun 9, 2022
@MingjiHan99 MingjiHan99 deleted the fix-ci branch June 9, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants