Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iceberg): fix iceberg time travel timezone #20085

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Jan 9, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Example

set timezone = 'asia/shanghai';
select * from t for system_time as of '2025-01-09 15:12:50.669';

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/fix Bug fix label Jan 9, 2025
@chenzl25 chenzl25 requested a review from zwang28 January 9, 2025 08:17
@chenzl25 chenzl25 enabled auto-merge January 9, 2025 09:34
@chenzl25 chenzl25 added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 3619d77 Jan 9, 2025
28 of 29 checks passed
@chenzl25 chenzl25 deleted the dyaln/fix_iceberg_time_travel_timezone branch January 9, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: iceberg time travel timestamp should respect session timezone
2 participants