Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make rustc nigthly work by drop cursor_remaining #18764

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/common/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#![feature(iter_order_by)]
#![feature(binary_heap_into_iter_sorted)]
#![feature(impl_trait_in_assoc_type)]
#![feature(map_entry_replace)]
#![feature(negative_impls)]
#![feature(register_tool)]
#![feature(btree_cursors)]
Expand Down
6 changes: 5 additions & 1 deletion src/storage/hummock_trace/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#![feature(cursor_remaining)]
// FIXME: open the assert when 1.8.2 is stable that can use #![feature(cursor_split)] instead of #![feature(cursor_remaining)]

// see: https://github.com/rust-lang/rust/pull/109174
// #![feature(cursor_remaining)]

#![feature(trait_alias)]
#![feature(coroutines)]

Expand Down
7 changes: 6 additions & 1 deletion src/storage/hummock_trace/src/read.rs
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,12 @@ mod test {
}

assert!(deserializer.deserialize(&mut buf).is_err());
assert!(buf.is_empty());
// FIXME: use buf.is_empty() when 1.8.2 is stable that can use #![feature(cursor_split)] instead of #![feature(cursor_remaining)]

// see: https://github.com/rust-lang/rust/pull/109174
// assert!(buf.is_empty());

assert_eq!(buf.get_ref().len() as u64 - buf.position(), 0);
}

#[test]
Expand Down
Loading