Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(prost): optimize some Debug representation #18111

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Aug 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Omit optional fields. e.g., a lot of fields in DataType is only for complex types.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Aug 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan force-pushed the 08-14-refactor_add_some_comments_for_mv_progress_tracking branch from c40d01d to 9e34c99 Compare August 23, 2024 05:39
@xxchan xxchan marked this pull request as ready for review August 23, 2024 05:39
@xxchan xxchan force-pushed the 08-15-refactor_prost_optimize_some_debug_representation branch from 2a91599 to 9460191 Compare August 23, 2024 05:39
@xxchan xxchan requested a review from BugenZhao August 23, 2024 05:47
@xxchan xxchan merged commit 8bf4b4d into 08-14-refactor_add_some_comments_for_mv_progress_tracking Aug 23, 2024
9 of 20 checks passed
@xxchan xxchan deleted the 08-15-refactor_prost_optimize_some_debug_representation branch August 23, 2024 05:48
xxchan added a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant