Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: render empty strings #47

Merged
merged 2 commits into from
Jun 9, 2022
Merged

fix: render empty strings #47

merged 2 commits into from
Jun 9, 2022

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jun 9, 2022

Signed-off-by: Noel Kwan [email protected]

Closes #46.

Thanks to @skyzh for pointing out relevant lines of code :)

@kwannoel kwannoel force-pushed the kwannoel/render-empty-strings branch from d089efc to f65217c Compare June 9, 2022 08:39
@kwannoel
render empty strings
1670bc9 
Signed-off-by: Noel Kwan <[email protected]>
@kwannoel kwannoel force-pushed the kwannoel/render-empty-strings branch from f65217c to 1670bc9 Compare June 9, 2022 08:40
skyzh
skyzh approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you please also bump version to 0.5 in Cargo.toml and update the change log (as this change default behavior)? I'll release a new version maybe tonight, and we can start using it maybe tomorrow.

@kwannoel kwannoel changed the title render empty strings fix: render empty strings Jun 9, 2022
@kwannoel kwannoel force-pushed the kwannoel/render-empty-strings branch from ec0a0f9 to dbd2eec Compare June 9, 2022 09:27
@skyzh skyzh enabled auto-merge (squash) June 9, 2022 09:29
@skyzh skyzh merged commit 8077294 into risinglightdb:main Jun 9, 2022
@kwannoel kwannoel deleted the kwannoel/render-empty-strings branch June 9, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print (empty) for empty strings
2 participants
@kwannoel @skyzh