-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix query/statement error
unexpected passed when result is statement/query ok
#187
Conversation
Signed-off-by: JackTan25 <[email protected]>
@xxchan please review? |
sqllogictest/src/runner.rs
Outdated
#[error( | ||
"{kind} is expected to fail with error:\n\t{expected_err}\nbut pass test\n[SQL] {sql}" | ||
)] | ||
MismatchPass { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the same as TestErrorKind::Ok
?
} | ||
.at(loc)); | ||
} | ||
} | ||
( | ||
Record::Query { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this branch has the same problem and can be fixed in the same way. Would you mind fixing it together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
query/statement error
unexpected passed when result is statement/query ok
Signed-off-by: JackTan25 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
0.15.1 published |
thanks |
No description provided.