Simplify some base instruction execute clauses #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timmmm
force-pushed
the
user/timh/snippet_refactor
branch
from
d0317a2 to
0127442
Compare
jordancarlin
approved these changes
Feb 12, 2025
Refactor some of the base `execute` clauses to remove intermediate variables and unnecessary `if`s. The motivation for this is to make them read a bit better when included in the ISA manual. 1. Make `shift_right_arith` generic so you don't need a 32/64-bit version. 2. Use `rs1_val` in fewer places - it's actually longer than `X(rs1)` anyway. 3. Directly assign to `X(rd)` where possible. 4. Avoid single letter variables.
I think this makes it a bit clearer, rather than having a random `+ 2` in there. If we had half-open intervals then it would be even nicer: `[log2_xlen >.. 0]`.
Timmmm
force-pushed
the
user/timh/snippet_refactor
branch
from
0127442 to
9d1b7bc
Compare
|
I added |
jordancarlin
approved these changes
Feb 13, 2025
Timmmm
added
the
will be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor some of the base
executeclauses to remove intermediate variables and unnecessaryifs. The motivation for this is to make them read a bit better when included in the ISA manual.shift_right_arithgeneric so you don't need a 32/64-bit version.rs1_valin fewer places - it's actually longer thanX(rs1)anyway.X(rd)where possible.