-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicates: xperm.n == xperm4, xperm.b == xperm8, rev.b == brev8 #1518
Comments
The fundamental problem, IMO, is the duplication of the Zbkb, Zbkc, and Zbkx specs between the bitmanip and scalar crypto chapters. I think it makes the most sense to consolidate them into the bitmanip chapter, but fix the mnemonics to correspond to the ones in the scalar crypto chapter, as you suggest. If someone can make a PR that does this, I'd be happy to review it. |
I will take care of this PR. |
@mjosaarinen My PR fixes the mnemonics: #1524 Since no good deed goes unpunished, can you sanity-check Zbkb/Zbkc/Zbkx in the bitmanip chapter? I did some spot checks. The opcodes look right, but you might want to check them anyway. The SAIL code is differently formatted, though. (I didn't check its semantics.) If you have any recommendations, please follow up with a PR, which I'll be happy to review. |
Thanks, Here are some things from the review: There's a typo here: riscv-isa-manual/src/scalar-crypto.adoc Line 3356 in 568e50a
As you note, it would be great if Typesetting of sail for riscv-isa-manual/src/scalar-crypto.adoc Line 3436 in 568e50a
The sail definitions in bitmanip retain the old names in pseudocode; e.g. riscv-isa-manual/src/b-st-ext.adoc Line 3568 in 568e50a
Furthermore on the bitmanip version retains the old names in links. riscv-isa-manual/src/b-st-ext.adoc Line 988 in 568e50a
Cheers, |
PR from the review #1531 |
Cleanup for of XPERM4, XPERM8, BREV8 ( #1518 )
Many thanks. I'll consider this one resolved for now. |
This can be confusing and I don't see why it would be intentional:
I recall that (Krste) requested us to change the names of { rev.b, xperm.n, xperm.b } from the bitmanip names in late stages of scalar crypto ratification -- just before the public review. So we changed those. I guess the old names made a comeback from the old bitmanip specification into the merged spec?
Here's the original issue that motivated the change: riscv/riscv-crypto#115
For scalar crypto the change happened for v1.0.0-rc2 in September 2021: https://github.com/riscv/riscv-crypto/releases/tag/v1.0.0-rc2-scalar
The text was updated successfully, but these errors were encountered: