-
Notifications
You must be signed in to change notification settings - Fork 652
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Delete more nonexistent extensions from the naming constraints
- Loading branch information
1 parent
6b1754c
commit f5f9c27
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5f9c27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need this order here, otherwise we didn't know what the right canonical order among zb*, zk* and other z* extensions.
FYI: @a4lg
f5f9c27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned on the issue tracker, my opinion is that enforcing the order be canonicalized is the bug. It doesn’t really matter whether Zj* comes before or after Zk*, and enforcing this ordering makes it harder to compose ISA strings. Making the ordering rules strict creates more problems than it solves.
f5f9c27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it doesn’t really matter whether Zj* comes before or after Zk*, but it does matter for zv*, zb* and zk*, I am not intend to argue the usability of the order here, it's defined in ISA spec, and most SW tools follow that, and that still existing in ISA spec so we try to follow that and disambiguate if possible, if that really NOT matter, that should really removed from the spec.
f5f9c27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am saying that IMO ordering should not matter for Zv*, Zb*, etc., either. I know that relaxing this would affect the tools, but relaxations are backwards-compatible. In any case, the spec will be updated once the decision is made. No decision has been made yet.
f5f9c27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I should push this riscv-non-isa/riscv-toolchain-conventions#14 more hard :P