-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rv32 sha512sigDX wrong order #128
Comments
Also note that OpenSSL marks |
Nice catch! Thank you, I will update this in the spec when I have some time on Wednesday. You're absolutely right about how it was a typo, I must have copied the example and forgotten to change the registers. |
- Register ordering of examples was wrong. See Issue #128 On branch master Your branch is up-to-date with 'origin/master'. Changes to be committed: modified: insns/sha512sig0h.adoc modified: insns/sha512sig0l.adoc modified: insns/sha512sig1h.adoc modified: insns/sha512sig1l.adoc
Hi @marcfedorow - I've updated the spec in 1b66e0a - it turns out several instructions had the same typo. Thanks again for spotting this, I'll leave the issue open in case others spot it to avoid duplicates. |
Note to software developers says:
This is not true. Actually sigma0 transform for SHA2-512 may be computed on RV32 using the following
It is obviously a typo whilst this instruction is
ror
-based (assha512sum0r
).The text was updated successfully, but these errors were encountered: