Collection of fixes #191
Merged
Collection of fixes #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As raised by Atish, this event is designated for the PMU overflow event. Disambiguate that by renaming the local PMU event to local PMU overflow event. Reviewed-by: Atish Patra <[email protected]> Signed-off-by: Clément Léger <[email protected]>
Some events might only be supported if there is hardware support for them (such as the PMU overflow one for instance). In that case, returning SBI_ERR_NOT_SUPPORTED would allow to differentiate between valid events but not supported and non valid events in which case SBI_ERR_INVALID_PARAM is returned. Reviewed-by: Atish Patra <[email protected]> Signed-off-by: Clément Léger <[email protected]>
For SSE, we are returning SBI_ERR_NOT_SUPPORTED if the event is valid but missing dependencies (either hardware or SBI does not implements it). In order to be coherent with that description, align the firmware feature one. Reviewed-by: Atish Patra <[email protected]> Signed-off-by: Clément Léger <[email protected]>
What we mean by long is XLEN; C defines the width of long to be: * at least the width of int, * at least 32 bits wide, * and no more that the width of long long SBI specification is not coupled with any C ABI and SBI implementation must not care about what language the supervisor is using, so our pseudocode definition should provide the explicit sizes of data types. Reviewed-by: Atish Patra <[email protected]> Signed-off-by: Radim Krčmář <[email protected]>
Unused input registers are currently unspecified, so define them to keep their behavior the same, which allows the supervisor software to optimize the unused inputs. Reviewed-by: Atish Patra <[email protected]> Signed-off-by: Radim Krčmář <[email protected]>
Bring the invalid value error in line with other pmu calls. Reviewed-by: Anup Patel <[email protected]> Reviewed-by: Atish Patra <[email protected]> Signed-off-by: Radim Krčmář <[email protected]>
Forcing reserved bits to zero allows us to enable future flags by simply increasing the SBI implementation version. Reviewed-by: Anup Patel <[email protected]> Reviewed-by: Atish Patra <[email protected]> Signed-off-by: Radim Krčmář <[email protected]>
Reserved bits must be zero. If we didn't do this, future flags would also need to introduce a separate feature toggle that would have to be enabled by the supervisor before using this flag. Signed-off-by: Radim Krčmář <[email protected]>
"should be zero" does not prevent supervisor from writing random data. If we want to use those bits in the future, it is more flexible to force them to zero now. Reviewed-by: Anup Patel <[email protected]> Signed-off-by: Radim Krčmář <[email protected]>
Force reserved flag bits to be zero and get rid of the different wording on one of them. Reviewed-by: Anup Patel <[email protected]> Reviewed-by: Atish Patra <[email protected]> Signed-off-by: Radim Krčmář <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.