Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved the bug in ISAC -> local variable 'yaml' referenced before assignment #556

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

UmerShahidengr
Copy link
Collaborator

PR #549 triggered an error in ISAC in util.py i.e, local variable 'yaml' referenced before assignment. I have given its fix

@UmerShahidengr
Copy link
Collaborator Author

@MuhammadHammad001 it is fixed now.
@allenjbaum can you please merge this one?

Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple update to newer version of yaml tool

@trdthg
Copy link
Contributor

trdthg commented Nov 10, 2024

@UmerShahidengr
Copy link
Collaborator Author

wait, looks like you redefined the create_yaml?

Yes, I had to redefine it because without this function, ISAC was giving unreferenced error on yaml as it was getting defined in a if-condition only. The updated definition of create_yaml() is resolving that error.

@UmerShahidengr UmerShahidengr merged commit 7a02abe into riscv-non-isa:dev Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants