Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flh-align-01] fix ISA config in RVTEST_CASE macro #451

Merged
merged 3 commits into from
Apr 15, 2024
Merged

[flh-align-01] fix ISA config in RVTEST_CASE macro #451

merged 3 commits into from
Apr 15, 2024

Conversation

stnolting
Copy link
Contributor

Fixing #448

allenjbaum
allenjbaum approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an outlier in Zfh tests

allenjbaum
allenjbaum requested changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - this won't go through unless you also add something a new entry in the changelog file

@stnolting
Update CHANGELOG.md
b28e65e 
Signed-off-by: stnolting <[email protected]>
@stnolting
Update CHANGELOG.md
f70ea15 
Signed-off-by: stnolting <[email protected]>
@stnolting
Copy link
Contributor Author

Oops - this won't go through unless you also add something a new entry in the changelog file

Done.

@stnolting stnolting requested a review from allenjbaum April 13, 2024 13:06
allenjbaum
allenjbaum approved these changes Apr 13, 2024
View reviewed changes
Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the change log entry. Note that when we get the dev branch process going, maintainers will be responsible for the changelog, using committ messages for all staged PRs for that release.

@stnolting stnolting mentioned this pull request Apr 14, 2024
Closed
@allenjbaum allenjbaum merged commit c443e5c into riscv-non-isa:main Apr 15, 2024
1 check passed
@stnolting stnolting deleted the patch-1 branch April 15, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenjbaum allenjbaum allenjbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnolting @allenjbaum