Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing check ISA fields in RVTEST_CASE for new div and amo tes… #398

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

davidharrishmc
Copy link
Contributor

Fixed missing check ISA fields in RVTEST_CASE for new div and amo tests. Without these fields, RISCOF reports 'Test Selected without the relevant extensions being available on DUT.'

Description

Inserted check ISA:=regex(.32.); or check ISA:=regex(.64.); into the new AMO tests and the revised div tests.

This does not modify any test coverage, but fixes an error I was seeing that RISCOF attempted to select 32-bit tests on 64-bits and vice versa.

INFO | Running Build for Reference

ERROR | Error in test: /home/harris/cvw/addins/riscv-arch-test/riscv-test-suite/rv32i_m/A/src/amoadd.w-01.S
Test Selected without the relevant extensions being available on DUT.

Related Issues

N/A

Ratified/Unratified Extensions

  • [ x] Ratified
  • Unratified

List Extensions

A, M

Reference Model Used

  • [x ] SAIL
  • [ x] Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • [ x] All tests are compliant with the test-format spec present in this repo ?
  • [ x] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • [ n/a] Ran the new tests on RISCOF in coverage mode
  • [ n/a] Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • [ n/a] Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • [ x] Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
  • Were the tests hand-written/modified ?
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

davidharrishmc and others added 2 commits October 11, 2023 05:36
…ts. Without these fields, RISCOF reports 'Test Selected without the relevant extensions being available on DUT.'
@allenjbaum
Copy link
Collaborator

The .w options should be available for both RV32 and RV64. Only the .d versions are limited to RV64,
so I don't think you want to add the RV32 qualifier for them..

Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem. Sorry it took so long to get to.

@allenjbaum allenjbaum merged commit 544665f into riscv-non-isa:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants