Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zext.h-01.S #310

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Update zext.h-01.S #310

merged 2 commits into from
Feb 8, 2023

Conversation

davidharrishmc
Copy link
Contributor

@davidharrishmc davidharrishmc commented Feb 8, 2023

Remove RV64IB from the ISA string.

The RV64IB ISA causes a compilation string of -march=rv64ib and thus a gcc error "cannot find default versions of the ISA extension 'b'".

This is the only test in riscv-arch-test that specifies RV64IB. I believe it is a typo and should be removed. When I remove it, riscof produces a Makefile that compiles zext.h-01 successfully.

Signed-off-by: David Harris [email protected]

Description

Provide a detailed description of the changes performed by the PR.

Related Issues

Please list all the issues related to this PR. Use NA if no issues exist

Ratified/Unratified Extensions

  • Ratified
  • Unratified

List Extensions

List the extensions that your PR affects. In case of unratified extensions, please provide a link to the spec draft that was referred to make this PR.

Reference Model Used

  • SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • All tests are compliant with the test-format spec present in this repo ?
  • Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • Ran the new tests on RISCOF in coverage mode
  • Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
  • Were the tests hand-written/modified ?
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

Remove RV64IB from the ISA string.

The RV64IB ISA causes a compilation string of -march=rv64ib and thus a gcc error "cannot find default versions of the ISA extension 'b'".

This is the only test in riscv-arch-test that specifies RV64IB.  I believe it is a typo and should be removed.  When I remove it, riscof produces a Makefile that compiles zext.h-01 successfully.

Signed-off-by: David Harris <[email protected]>
@allenjbaum
Copy link
Collaborator

OK, this is another weird case; this should have been caught by CI tests I would think. (or is it GCC that just changed?)

@pawks
Copy link
Collaborator

pawks commented Feb 8, 2023

@davidharrishmc Will need a changelog update to merge this. I believe the tests were run with the older gcc before being checked in. Nice catch!

@davidharrishmc
Copy link
Contributor Author

I'm not sure how to make a changelog entry and associate it with this PR. The entry should say

"Remove RV64IB from the ISA string for zext.h-01 because it is no longer compatible with GCC 12.2"

@pawks pawks merged commit a3b7f0c into riscv-non-isa:main Feb 8, 2023
@pawks
Copy link
Collaborator

pawks commented Feb 8, 2023

Thanks for the PR. Updated and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants