Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fnmadd.d_b15, fmadd.d_b15, fnmsub.d_b15, and fmsub.d_b15 have incorrect RVTEST_ISA values #488

Closed
jordancarlin opened this issue Sep 5, 2024 · 3 comments · Fixed by #489

Comments

@jordancarlin
Copy link
Contributor

Prior to #486 these tests had RVTEST_ISA("RV32IFD_Zicsr,RV64IFD_Zicsr").

After the split this was changed to RVTEST_ISA("RV32IF_Zicsr,RV32IFD_Zicsr,RV64IF_Zicsr,RV64IFD_Zicsr,RV32EF_Zicsr,RV32EFD_Zicsr,RV64EF_Zicsr,RV64EFD_Zicsr").

The new value causes the following error because it is selected with only the F extension even though these are D instructions.
Error: unrecognized opcode 'fmadd.d f31,f30,f29,f28,dyn', extension 'd' or 'zdinx' required

@UmerShahidengr
Copy link
Collaborator

Thanks for pointing that out. It will be reverted to the old RVTEST_ISA string soon.

@UmerShahidengr
Copy link
Collaborator

Thanks for the PR @jordancarlin , it will be merged soon and this issue will be closed.

@jordancarlin
Copy link
Contributor Author

Perfect. Thanks for the prompt action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants