Fix data types around opcodes.h and program.{c,h} #1225
+270
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en-sc
requested changes
Feb 12, 2025
- Fix and clean-up datatypes in opcodes.h and program.{c,h}.
Some of the changes were pointed by -Wconversion, others
come from manual code inspection.
- Remove commented code from opcodes.h (unused for very long time).
- Add assertions to opcodes.h to check that instruction
immediates (and other fields) don't exceed their range.
Change-Id: I7fc7c30ac2fdb00a93158d63d1379e7f16b1d168
Signed-off-by: Jan Matyas <[email protected]>
This is to make it consistent with stdint.h. Change-Id: Ibba824dad431b3a1675700ad4cc15f3e39a187f7 Signed-off-by: Jan Matyas <[email protected]>
Callers of functions from opcodes.h need to be updated accordingly, too. Change-Id: Ic42156b2843be682bc1cf9c720b73687008a2aa6 Signed-off-by: Jan Matyas <[email protected]>
JanMatCodasip
force-pushed
the
jm-codasip/fix-datatypes-around-program
branch
from
364efb0 to
b272470
Compare
en-sc
reviewed
Feb 27, 2025
SSIA Change-Id: I3e0b2fad84411c530f56cdbe33f3d8b4dbf81cf6 Signed-off-by: Jan Matyas <[email protected]>
JanMatCodasip
force-pushed
the
jm-codasip/fix-datatypes-around-program
branch
from
8703654 to
64f30dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and clean-up data types in
opcodes.handprogram.{c,h}. Some of the changes were prompted by-Wconversion, others come from manual code inspection.Remove commented code from
opcodes.h(unused for very long time).Add assertions to
opcodes.hto check that instruction immediates (and other fields) don't exceed their range.Change-Id: I7fc7c30ac2fdb00a93158d63d1379e7f16b1d168