Remove target/riscv/asm.h #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en-sc
requested changes
Jan 17, 2025
JanMatCodasip
force-pushed
the
jm-codasip/remove-asm-h
branch
from
081238b to
c6b9cfa
Compare
The file asm.h is only used by riscv-011.c. Remove the whole asm.h file and inline the two functions into riscv-011.c which is the only place of use. Change-Id: Ifa4b2b87ab9f3f50c78a75361003ce478bfd9d5f Signed-off-by: Jan Matyas <[email protected]>
JanMatCodasip
force-pushed
the
jm-codasip/remove-asm-h
branch
from
c6b9cfa to
c1dfb0d
Compare
Addressed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the whole
asm.hfile and inline the two functions directly intoriscv-011.c, which is the only place where they are used.This is a code cleanup PR without any change of functionality.
Change-Id: Ifa4b2b87ab9f3f50c78a75361003ce478bfd9d5f