Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align include guards with OpenOCD coding guidelines #1104

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Align include guards with OpenOCD coding guidelines #1104

merged 1 commit into from
Aug 8, 2024

Conversation

TommyMurphyTM1234
Copy link
Collaborator

Third attempt after these two abortive attempts failed due to checkpatch and git complexity:

Fixes:

These include files have not been changed because they are programmatically generated elsewhere so any changes to their content would need to be done there and not here:

@TommyMurphyTM1234
Copy link
Collaborator Author

Check Code Style (checkpatch) / check (pull_request) Successful in 19s

Phew!

Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch!
Sorry for all the trouble with the Checkpatch.

@TommyMurphyTM1234
Copy link
Collaborator Author

Thanks @en-sc - sorry about all the confusion with the earlier PRs.

@aap-sc
Copy link
Collaborator

aap-sc commented Jul 9, 2024

@en-sc , @TommyMurphyTM1234 and I'm just sorry that I still haven't debugged #1049

@aap-sc
Copy link
Collaborator

aap-sc commented Aug 5, 2024

@JanMatCodasip , @MarekVCodasip FYI. Unless there is no objection in a day or two - I'm going to merge this one.

@en-sc en-sc merged commit 9a23c9e into riscv-collab:riscv Aug 8, 2024
4 checks passed
@TommyMurphyTM1234 TommyMurphyTM1234 deleted the fix-include-guards branch October 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants