You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Extensibility: Take abstract_..._supported for example. Current implementation assumes the support is the same across all the registers in a group.
Correctness: We should make sure abstractcs.cmderr == not_supported, not abstractcs.cmderr != none before asserting that the support is missing. This is not currently done in some places, e.g.
The idea is similar to #928.
The issue
Currently, there are many target properties derived from abstract command being supported or not:
riscv-openocd/src/target/riscv/riscv-013.c
Lines 178 to 183 in f32f178
There are issues with the current approach, e.g.:
abstract_..._supported
for example. Current implementation assumes the support is the same across all the registers in a group.abstractcs.cmderr == not_supported
, notabstractcs.cmderr != none
before asserting that the support is missing. This is not currently done in some places, e.g.riscv-openocd/src/target/riscv/riscv-013.c
Lines 3791 to 3807 in f32f178
Proposed solution
bsearch()
in the array).abstractcs.cmderr
isnot_supported
.The text was updated successfully, but these errors were encountered: