Use thumbprint instead of friendly name for certificate labels. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the friendly name property (CERT_FRIENDLY_NAME_PROP_ID) as the CKA_LABEL attribute value for a certificate can be problematic, as not all certificates have a value for this property. This has been seen to cause problems with NSS, where multiple certificates without friendly names were assigned the same nickname. This resulted in a browser only being able to access one of the certificates. This fix updates p11c_cert_certificate_get_bytes() to report the certificate's thumbprint instead (provided by the CERT_HASH_PROP_ID property). Thumbprints are commonly used to identify certificates on Windows systems, and can be calculated for any certificate (as they are simply a hash). Signed-off-by: Simon Haggett <[email protected]>
|
But identifying a certificate by a hash is not really user friendly. Wouldn't it be a better way to only use the thumbprint if the certificate has no friendly name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the friendly name property (CERT_FRIENDLY_NAME_PROP_ID) as the CKA_LABEL
attribute value for a certificate can be problematic, as not all certificates
have a value for this property. This has been seen to cause problems with NSS,
where multiple certificates without friendly names were assigned the same
nickname. This resulted in a browser only being able to access one of the
certificates.
This fix updates p11c_cert_certificate_get_bytes() to report the certificate's
thumbprint instead (provided by the CERT_HASH_PROP_ID property). Thumbprints
are commonly used to identify certificates on Windows systems, and can be
calculated for any certificate (as they are simply a hash).
Signed-off-by: Simon Haggett [email protected]