Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/175 #186

Closed
wants to merge 9 commits into from
Closed

Pr/175 #186

wants to merge 9 commits into from

Conversation

lythium23
Copy link

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

Please add details about your change here.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@soloturn
Copy link

soloturn commented Jul 8, 2024

ok i see. you have some url which works and works not depending this switch?

@joroto joroto mentioned this pull request Jul 28, 2024
5 tasks
@soloturn soloturn force-pushed the main branch 2 times, most recently from 75937eb to ca96ce8 Compare December 13, 2024 03:23
@metaprime
Copy link

Blanket SSL verification is dangerous at best and malicious at worst. #175 is a much better approach to have the option when necessary.

@soloturn soloturn closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants