Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get and set methods; deprecate data #122

Closed
joews opened this issue Feb 8, 2017 · 0 comments
Closed

Add get and set methods; deprecate data #122

joews opened this issue Feb 8, 2017 · 0 comments
Assignees

Comments

@joews
Copy link
Member

joews commented Feb 8, 2017

Setting the value through MaterialDateTimePicker#data(newValue) doesn't set the value correctly, and overloading data for get/set is not a friendly API design.

Bug: picker.set(newDatetime) does not set the picker's time where newDatetime differs from the picker's current time in both date and time.

  • Add get, which always returns the current value as a moment
  • Add a deprecation warning to data() / data(nextValue). Mark for removal in a future release.
  • Fix behaviour of set where both the date and time change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant