Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: fix touchable area #253

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Select: fix touchable area #253

merged 3 commits into from
Jul 29, 2021

Conversation

3rdvision
Copy link
Contributor

- -
Issue https://github.com/ripe-tech/ripe-id-mobile/issues/5#issuecomment-888248323 - select touchable area is not properly covering the arrow icon.
Decisions - Add component fix prop fixAndroidTouchableBug

@3rdvision 3rdvision added the bug Something isn't working label Jul 29, 2021
@3rdvision 3rdvision requested a review from gcandal July 29, 2021 11:07
@ripe-tobias-bot
Copy link

Woof, Woof!

Thank you for submitting the "Select touch" pull request 😎.

Please do not forget to review our internal guidelines:

  • Review the code in the PR using a peer 🧑‍🤝‍🧑
  • Make sure all the linting process has been executed an passed 👌
  • Make sure unit tests are passing ✅
  • Ensure that proper code standards are met 📋
  • Fill in the PR's summary (issue, dependencies, decisions and GIF)
  • Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@3rdvision 3rdvision changed the title Select touch Select: fix touchable area Jul 29, 2021
@gcandal
Copy link
Contributor

gcandal commented Jul 29, 2021

@3rdvision please make this an optional prop that defaults to true.

@gcandal gcandal assigned 3rdvision and unassigned gcandal Jul 29, 2021
@3rdvision 3rdvision assigned gcandal and unassigned 3rdvision Jul 29, 2021
@gcandal gcandal assigned joamag and unassigned gcandal Jul 29, 2021
@joamag joamag merged commit be54739 into master Jul 29, 2021
@joamag joamag deleted the dva/select_touch branch July 29, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcandal gcandal gcandal approved these changes

@joamag joamag joamag approved these changes

Assignees

@joamag joamag

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3rdvision @gcandal @joamag