Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market integration #164

Merged
merged 3 commits into from
May 6, 2023
Merged

Market integration #164

merged 3 commits into from
May 6, 2023

Conversation

hayribakici
Copy link
Collaborator

@hayribakici hayribakici commented May 5, 2023 •
edited
Loading

This PR integrates the new Market enum into methods signature as a parameter, thus replacing the String? market with Market? market.

@hayribakici hayribakici requested a review from rinukkusu May 5, 2023 20:06
rinukkusu
rinukkusu approved these changes May 6, 2023
View reviewed changes
Copy link
Owner

@rinukkusu rinukkusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM! 😻

@rinukkusu rinukkusu merged commit 3381905 into rinukkusu:master May 6, 2023
@hayribakici hayribakici deleted the market_integration branch May 6, 2023 14:20
@hayribakici
Copy link
Collaborator Author

@rinukkusu I am wondering, if Market also should be used with Album.availableMarkets?

@rinukkusu
Copy link
Owner

Hmmm, yes - we probably want it everywhere a country or market is being "used".

@hayribakici hayribakici mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinukkusu rinukkusu rinukkusu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayribakici @rinukkusu