Remove duplicated code to detect Rust keywords/identifiers #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kijewski
reviewed
Jun 23, 2024
| // Since the individual buckets are quite short, a linear search is faster than a binary search. | ||
| kws[ident_len] | ||
| .iter() | ||
| .any(|&probe| padded_ident == &probe[2..]) |
There was a problem hiding this comment.
Interesting! You are right, the
padded_ident == <[u8; parser::node::MAX_KW_LEN]>::try_from(&probe[2..]).unwrap()"optimization" is not needed anymore, and now the same code generated with and without it. When I first wrote the search, it was still needed because otherwise the assembly would needlessly contain length checks.
There was a problem hiding this comment.
Oh interesting. I checked and couldn't find out why it was needed. I suppose rustc/LLVM got better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #23.
cc @Kijewski