Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid condition optimization #171

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix invalid condition optimization #171

merged 1 commit into from
Sep 11, 2024

Conversation

GuillaumeGomez
Copy link
Contributor

The ! operator was removed, which is pretty bad. ^^'

Kijewski
Kijewski approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@Kijewski Kijewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b || !b?

@Kijewski Kijewski merged commit 548036f into rinja-rs:master Sep 11, 2024
34 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-invalid-cond-opt branch September 11, 2024 17:50
@GuillaumeGomez
Copy link
Contributor Author

Sending a PR for this case too.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 11, 2024
Merged
@Kijewski
Copy link
Collaborator

Kijewski commented Sep 11, 2024 •
edited
Loading

Hehe, that meant as a "to be or not to be" joke, but more tests are welcome! :)

@GuillaumeGomez
Copy link
Contributor Author

I'm too jetlagged for that. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kijewski Kijewski Kijewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @Kijewski