parser: add context information for unknown tags #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kijewski
force-pushed
the
pr-no-such-tag
branch
from
44849ce to
4e4a5fe
Compare
|
Please view the diff ignoring whitespaces changes, or it's entirely unreadable. |
| move |i: &'a str| { | ||
| let result = inner(i); | ||
| if let Err(nom::Err::Failure(err) | nom::Err::Error(err)) = &result { | ||
| if err.message.is_none() { |
There was a problem hiding this comment.
I can't wait for the if let chain feature to be stable...
There was a problem hiding this comment.
Yeah, I would like to remove a lot of let Some(_) = f() else { return; }*5 instances, too.
GuillaumeGomez
previously approved these changes
Sep 10, 2024
|
This is super cool, thanks! I'll need to re-approve once merge conflicts are fixed I think. ^^' |
Kijewski
force-pushed
the
pr-no-such-tag
branch
from
4e4a5fe to
1948d63
Compare
Thank you! :) Yes, oftentimes I was baffled myself why something does not parse correctly, so I hope this PR makes it clearer what is actually going on.
Indeed :) |
GuillaumeGomez
approved these changes
Sep 10, 2024
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.