derive: allow split up template attributes #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In generated code or macros, it might be useful to emit multiple `#[template]` attributes. E.g. ```rust #[template(source = "Hello!")] #[template(ext = "txt")] struct Hello; ```
Kijewski
force-pushed
the
pr-template-times-x
branch
from
c75e32a to
f25dac9
Compare
|
Nice add! Can you add a test like this please: #[derive(Template)]
#[template(source = "bla")]
#[template(source = "bla")]
struct Foo;Just to confirm the parsing of attributes is taking duplicates into account when they are not in the same attribute. |
That's done in https://github.com/rinja-rs/rinja/pull/117/files#diff-d2f7c348bb75850b1706f0efcd72e6b6c82baff6803d2e0aa5ca0521fe159ad2. Before it failed because there were two |
GuillaumeGomez
approved these changes
Aug 7, 2024
|
Oh wow, how did I miss that... Sorry for missing it. Thanks! |
Hehe, don't worry. I could have made the it more explicit bei adding a new test instead of changing the meaning of an existing one. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In generated code or macros, it might be useful to emit multiple
#[template]attributes. E.g.