derive: better use of spans and file information in error messages #102

Kijewski · 2024-07-29T03:01:16Z

No description provided.

GuillaumeGomez · 2024-07-29T09:04:44Z

testing/tests/ui/filter_block_ws.stderr

-error: failed to parse template source at row 1, column 27 near:
-       " %}\nHELLO\n{{v}}\n{%- endfilter %}"
+error: failed to parse template source
+ --> <source attribute>:1:28


For this one we could actually get the current file name.

I don't think that we know from which file we were called, do we? Not until rust-lang/rust#54725 lands. And the path is written just below this error message, so I don't think that is matters much.

Kijewski · 2024-07-29T12:01:50Z

It's a huge diff, but I think it's worth it. At least to me error messages are now much more readable.

I cannot get vmware to run my windows VM for quite some time, so I cannot test if it works in windows, too.

rinja_derive/src/input.rs

GuillaumeGomez · 2024-07-29T13:54:30Z

testing/tests/ui/as-primitive-type.stderr

  |
-3 | #[derive(Template)]
-  |          ^^^^^^^^
+       1 | {{ 1234 as 4567 }}


Btw, is it normal to have this super wide space starting here?

It is aligned to start after "error: ", because it belongs to the rust source that is printed below. At first, I did not find out how to remove the indentation, now I kinda like it, because it gives you a visual "this happened because of that" hint.

I have to admit I hate it. ^^'

I'd prefer if we kept coherency with rustc (with columns aligned to the one with the biggest line error number):

$ rustc foo.rs error[E0425]: cannot find value `Ba` in this scope --> foo.rs:10:13 | 7 | pub struct Bar; | --------------- similarly named unit struct `Bar` defined here ... 10 | let x = Ba; | ^^ help: a unit struct with a similar name exists: `Bar` error: aborting due to 1 previous error

rinja_derive/src/config.rs

Kijewski · 2024-07-29T16:46:04Z

821a147. In my terminal I can see the messages, but they aren't captured by trybuild or vs code. I guess that proc_macros aren't supposed to just print something into stderr. Maybe I have to wrap the output in some magic message, but if so, I have no idea what.

GuillaumeGomez · 2024-07-29T18:56:26Z

rinja_derive/src/lib.rs

+        }) => {
+            let msg = if rendered {
+                eprintln!("{msg}");
+                "the previous template error derives from"


Funny that only this part of the error message is displayed. Dark magic.

Kijewski · 2024-07-29T20:00:50Z

I removed the formatting/pretty printing of the annotation in the last commit. Maybe we can merge this stuff for now? Even without the pretty output, it has a ton of minor improvements. I would then open a new PR to get the pretty rendering going.

testing/tests/ui/broken-config.stderr

GuillaumeGomez · 2024-07-30T13:39:38Z

Looks good, thanks a lot!

derive: properly display error locations

380ecc1

Kijewski force-pushed the pr-annotate-snippets branch from 4aea79a to 380ecc1 Compare July 29, 2024 03:05