forked from jaegertracing/jaeger-client-cpp
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We need a newer Thrift to support hosts with openssl 1.1. Since Jaeger its self requires a c++11 compiler and nlohmann-json requires at least g++ 4.9, supporting newer dependencies makes sense. But Thrift 0.9.2 didn't support openssl 1.1. This is some pretty brutal surgery: - Remove crossdock and zipkin support entirely. The IDL is broken for C++ / Thrift generates bad code for it. See jaegertracing/jaeger-idl#35, https://issues.apache.org/jira/browse/THRIFT-4484 jaegertracing#45 - Adapt Thrift's namespace-aliasing approach to support Thrift built with use of std::smart_ptr or boost::smart_ptr; Thrift switched to std::smart_ptr in later versions but retains boost::smart_ptr for BC. - Regenerate IDL with Thrift 0.11.0 and commit in-tree. Unsure if Hunter still works; may need to package Thrift 0.11.0 Haven't tested with a Thrift configured with Boost smart pointers. Don't do that. The wholesale removal of zipkin and crossdock support means this is unlikely to be committable to mainline. Hopefully Thrift will fix their codegen. If not, well, we're probably going to throw Thrift out entirely soon.
- Loading branch information
Showing
67 changed files
with
1,327 additions
and
5,981 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.