Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relayer could make dispatch false by set wrong gas limit. #166

Closed
hujw77 opened this issue May 21, 2024 · 1 comment · Fixed by #169
Closed

Relayer could make dispatch false by set wrong gas limit. #166

hujw77 opened this issue May 21, 2024 · 1 comment · Fixed by #169
Assignees
@hujw77

Comments

@hujw77
Copy link
Collaborator

hujw77 commented May 21, 2024

https://github.com/msgport/ORMP/blob/7eb070df35c97deb7e827d6d225e93b69335e9a9/src/ORMP.sol#L142C8-L142C69

https://github.com/safe-global/safe-smart-account/blob/5feb0d08f59cfbb44918be1ed5889d9bb634562a/contracts/Safe.sol#L164C13-L164C47
@hujw77
Copy link
Collaborator Author

hujw77 commented May 21, 2024 •
edited
Loading

@hujw77 hujw77 self-assigned this May 21, 2024
hujw77 added a commit that referenced this issue May 21, 2024
@hujw77
fix #166
9b4af25
@hujw77 hujw77 mentioned this issue May 22, 2024
Merged
@jiguantong jiguantong moved this to Todo in Msgport May 22, 2024
@jiguantong jiguantong moved this from NoStatus to In Progress in Msgport May 22, 2024
hujw77 added a commit that referenced this issue May 22, 2024
@hujw77
Check relayer provide correct gas (#169)
34f2c61 
* fix tests

* fmt

* fix #166

* test

* unlink
@github-project-automation github-project-automation bot moved this from In Progress to Done in Msgport May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hujw77 hujw77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check relayer provide correct gas ringecosystem/ORMP
1 participant
@hujw77