-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Sparkle from source #493
Conversation
I lean towards using an official binary release.
Cons:
The flexibility to build for other architectures is not a big issue. A universal build is sufficient. |
Well, it's an option, I don't have particular preference. But the reasons of building from source are:
I actually like the previous experiment with SPM, but it just turns out SPM is not reliable enough, but submodule is reliable enough, and is equivalent in functionality. |
f229bdc
to
b54e60f
Compare
Build passed, I forgot to |
�Reasonable. Let me have a try. |
I quickly gave up the try. |
Sparkle source code is 12MB in size, it’s large, but not unacceptably large. Capnproto is 8.3MB, opencc is 7.6MB, yaml is 6.6MB, all these third party reps are cloned with a combined size way larger than sparkle. 30% increase in building time is a thing, but that’s still nothing compared to librime, and librime’s dependency build time. Like for librime, people want to avoid building the deps can just use the precompiled binary, it’s the same for Sparkle, once there is already |
I'm sitting on the fence. |
Of course, it's a minor pull, and doesn't affect user |
3d99a00
to
f8d5daf
Compare
(cherry picked from commit 997a450)
1c08ef3
to
15dda89
Compare
Replaced with #749 |
Building Sparkle from source is more flexible in choosing between different architectures to support.