Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): provide a flavor of api using stdbool #877

Merged
merged 2 commits into from
May 19, 2024
Merged

Conversation

lotem
Copy link
Member

@lotem lotem commented May 16, 2024

API struct: RimeApi_stdbool
API entry function: rime_get_api_stdbool

BREAKING CHANGE: Rime 0.9 API are moved to rime_api_deprecated.h.
the deprecated API functions are still dll-exported.

@lotem lotem requested a review from LEOYoon-Tsaw May 16, 2024 15:35
@lotem lotem force-pushed the master branch 7 times, most recently from 74590c6 to 3f65cf9 Compare May 16, 2024 23:19
lotem added a commit to lotem/librime-lua that referenced this pull request May 18, 2024
the deprecated librime 0.9 API function declarations will be move to a
separeate header file rime_api_deprecated.h in
rime/librime#877
Copy link
Member

@LEOYoon-Tsaw LEOYoon-Tsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested compiling with 3 plugins: Lua, octagram and predict, and used rime_get_api_stdbool in Squirrel (imported to Swift), everything is working, including plugins which uses librime 1 standard API

@lotem
Copy link
Member Author

lotem commented May 18, 2024

updated: exclude rime_api_impl.h from installed header files.

Copy link
Member

@LEOYoon-Tsaw LEOYoon-Tsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no issue with the latest commit. And I tried replacing the 0.16.2 Squirrel's librime with this pr's artifact, it works.

@lotem lotem force-pushed the master branch 2 times, most recently from 94bc715 to e15034b Compare May 18, 2024 19:54
@LEOYoon-Tsaw LEOYoon-Tsaw mentioned this pull request May 19, 2024
2 tasks
hchunhui pushed a commit to hchunhui/librime-lua that referenced this pull request May 19, 2024
the deprecated librime 0.9 API function declarations will be move to a
separeate header file rime_api_deprecated.h in
rime/librime#877
API type: RimeApi_stdbool
API entry function: rime_get_api_stdbool
@lotem
Copy link
Member Author

lotem commented May 19, 2024

added unit test

@lotem lotem merged commit 6b1b41f into rime:master May 19, 2024
10 checks passed
Bambooin added a commit to Bambooin/trime that referenced this pull request Jun 14, 2024
The deprecated librime 0.9 API function declarations will be move to a
separeate header file rime_api_deprecated.h in rime/librime#877
Bambooin added a commit to Bambooin/trime that referenced this pull request Jun 15, 2024
The deprecated librime 0.9 API function declarations will be move to a
separeate header file rime_api_deprecated.h in rime/librime#877
@Freed-Wu
Copy link
Contributor

rime_api_deprecated.h cannot work, because librime don't have Rime* functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants