-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): provide a flavor of api using stdbool #877
Conversation
74590c6
to
3f65cf9
Compare
the deprecated librime 0.9 API function declarations will be move to a separeate header file rime_api_deprecated.h in rime/librime#877
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested compiling with 3 plugins: Lua, octagram and predict, and used rime_get_api_stdbool in Squirrel (imported to Swift), everything is working, including plugins which uses librime 1 standard API
updated: exclude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no issue with the latest commit. And I tried replacing the 0.16.2 Squirrel's librime with this pr's artifact, it works.
94bc715
to
e15034b
Compare
the deprecated librime 0.9 API function declarations will be move to a separeate header file rime_api_deprecated.h in rime/librime#877
API type: RimeApi_stdbool API entry function: rime_get_api_stdbool
added unit test |
The deprecated librime 0.9 API function declarations will be move to a separeate header file rime_api_deprecated.h in rime/librime#877
The deprecated librime 0.9 API function declarations will be move to a separeate header file rime_api_deprecated.h in rime/librime#877
rime_api_deprecated.h cannot work, because librime don't have |
API struct:
RimeApi_stdbool
API entry function:
rime_get_api_stdbool
BREAKING CHANGE: Rime 0.9 API are moved to
rime_api_deprecated.h
.the deprecated API functions are still dll-exported.