fix(script_translator): correction can cause segfault #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the correction count limit doesn't really work, and it will take all candidates. When finding the candidates for the last page, ScriptTranslation::PrepareCandidate can return nullptr, leading to segfault.
lotem
reviewed
Apr 18, 2024
| @@ -431,7 +431,7 @@ bool ScriptTranslation::Next() { | |||
| } while (enable_correction_ && | |||
| syllabifier_->IsCandidateCorrection(*candidate_) && | |||
| // limit the number of correction candidates | |||
| ++correction_count_ > max_corrections_); | |||
There was a problem hiding this comment.
This while-loop is used to drop any correction candidates after the top N (max_corrections_).
If I didn't take it wrong, correction_count_ > max_corrections_ means exactly "correction candidates after the top N" so the loop goes on until the next non-correction candidate is found.
I recently updated this part. I might have broken it. Please blame and review my last change.
One thing that appear weird is the is_correction never set true.
This reverts commit 1feb30f.
it is the correct logic to discard more correction candidates after the top N; if reverted, all correction candidates except the top N are displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the correction count limit doesn't really work, and it will take all candidates. When finding the candidates for the last page, ScriptTranslation::PrepareCandidate can return nullptr, leading to segfault.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info