-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(key_binder): add when: predicting
condition
#751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the new condition `when: predicting` allow paging key binding to comma, period keys to be disabled when the active menu has tag `prediction`. it's used with the `predictor` component in the librime-predict plugin. see updates in data/minimal/default.yaml for example configuration.
eagleoflqj
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected in rime_api_console.
with this PR merged, looks like that librime-predict has been embedded not plugin. ) |
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 2, 2023
the new condition `when: predicting` allows paging key binding to comma, period keys to be disabled when the active menu has tag `prediction`. it's used with the `predictor` component in the librime-predict plugin. see updates in data/minimal/default.yaml for example configuration.
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
the new condition `when: predicting` allows paging key binding to comma, period keys to be disabled when the active menu has tag `prediction`. it's used with the `predictor` component in the librime-predict plugin. see updates in data/minimal/default.yaml for example configuration.
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
the new condition `when: predicting` allows paging key binding to comma, period keys to be disabled when the active menu has tag `prediction`. it's used with the `predictor` component in the librime-predict plugin. see updates in data/minimal/default.yaml for example configuration.
fxliang
pushed a commit
to fxliang/librime
that referenced
this pull request
Feb 2, 2024
the new condition `when: predicting` allows paging key binding to comma, period keys to be disabled when the active menu has tag `prediction`. it's used with the `predictor` component in the librime-predict plugin. see updates in data/minimal/default.yaml for example configuration.
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
the new condition `when: predicting` allows paging key binding to comma, period keys to be disabled when the active menu has tag `prediction`. it's used with the `predictor` component in the librime-predict plugin. see updates in data/minimal/default.yaml for example configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new condition
when: predicting
allow paging key binding to comma, period keys to be disabled when the active menu has tagprediction
.it's used with the
predictor
component in the librime-predict plugin. see updates in data/minimal/default.yaml for example configuration.