-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only log to a file without logging to stderr #799
Comments
I guess a compile-time flag should work for emacs-rime? FLAGS_alsologtostderr = RIME_LOG_TO_STDERR; |
allow turning on/off glog's alsologtostderr flag in custom build. by default OFF in release build, ON in debug build. Fixes rime#799
If possible, I want to use librime from my Linux distribution instead of changing cmake options and compiling it myself. So both a cmake option defaulting to off (the linked PR) and a rime api option work well for me. |
OK. I think it's appropriate to only enable logging to stderr in debug build. |
allow turning on/off glog's alsologtostderr flag in custom build. by default OFF in release build, ON in debug build. Fixes #799
allow turning on/off glog's alsologtostderr flag in custom build. by default OFF in release build, ON in debug build. Fixes rime#799
Is your feature request related to a problem? Please describe.
If Emacs runs inside a terminal emulator, using emacs-rime destroys the current screen of Emacs because librime logs to stderr.
Describe the solution you'd like
I want to be able to not log to stderr when logging is enabled.
Additional context
Removing this single line is a possible implementation. However, in that case, you have to set
log_dir
to an empty string to log to stderr, which is not very intuitive. In addition, this seems to be a breaking change.librime/src/rime/setup.cc
Line 81 in 72f833d
Maybe a new option should be added to rime api for this new feature.
The text was updated successfully, but these errors were encountered: