fix(glog): someone at google is to blame for linking error

rime · Feb 25, 2024 · 65cf8a0 · 65cf8a0
1 parent 20fdcc1
commit 65cf8a0
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -83,6 +83,8 @@ if(ENABLE_LOGGING)
     if(WIN32)
       add_compile_definitions("GLOG_DEPRECATED=__declspec(deprecated)")
       add_compile_definitions(GLOG_NO_ABBREVIATED_SEVERITIES)
+      # TODO: in glog v0.7.0, someone at Google forget to add dbghelp.lib to the linker library list.
+      target_link_libraries (dbghelp)
     else()
       add_compile_definitions("GLOG_DEPRECATED=__attribute__((deprecated))")
     endif()
@@ -93,6 +95,7 @@ if(ENABLE_LOGGING)
       add_compile_definitions("GLOG_EXPORT=__attribute__((visibility(\"default\")))")
       add_compile_definitions("GLOG_NO_EXPORT=__attribute__((visibility(\"default\")))")
     endif()
+
   endif()
 
   set(RIME_ENABLE_LOGGING 1)