feat: workspace breadcrumbs #6138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
briangregoryholmes
commented
Nov 22, 2024
•
briangregoryholmes
commented
ericpgreen2
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
This is great! It feels like these breadcrumbs might become the primary mode of navigation. Some UXQA:
- It's unclear to me when the downstream breadcrumbs are present. In this Jam, it looks like only the one-step-away downstream breadcrumb is shown. It'd be nice to show all downstream breadcrumbs.
- Could you add an e2e test for navigating through these breadcrumbs?
- I had a source & a metrics view, then I created a model from the source. The model's breadcrumb was named by the metrics view "Adbids_metrics", not by the model "Adbids_model":
Approving so you can merge at your discretion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.