Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workload examples to match new definitions #104

Merged
merged 2 commits into from
Apr 24, 2023
Merged

fix: workload examples to match new definitions #104

merged 2 commits into from
Apr 24, 2023

Conversation

JeremyLARDENOIS
Copy link
Contributor

I corrected some regression about pods workloads and creation instances

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code is documented
  • I provided unitary tests or procedure to test my code
  • My PR have a clear description of what my code is supposed to do

ℹ Additional Information

@JeremyLARDENOIS JeremyLARDENOIS requested a review from a team as a code owner April 24, 2023 15:11
@JeremyLARDENOIS JeremyLARDENOIS linked an issue Apr 24, 2023 that may be closed by this pull request
[BUG]: no longer possible to launch workloads examples #102
Closed
@alexandrebrg alexandrebrg changed the title 102 bug no longer possible to launch workloads examples fix: workload examples to match new definitions Apr 24, 2023
alexandrebrg
alexandrebrg approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@alexandrebrg alexandrebrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Indeed, we forgot to update examples when editing definitions, nice catch!

@alexandrebrg alexandrebrg added type/documentation Improvements or additions to documentation type/bug Something isn't working and removed type/bug Something isn't working labels Apr 24, 2023
@alexandrebrg alexandrebrg merged commit 50a7b27 into main Apr 24, 2023
@alexandrebrg alexandrebrg deleted the 102-bug-no-longer-possible-to-launch-workloads-examples branch April 24, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebrg alexandrebrg alexandrebrg approved these changes

Assignees
No one assigned
Labels
type/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: no longer possible to launch workloads examples
2 participants
@JeremyLARDENOIS @alexandrebrg