Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pickling a PyProgram by implementing __getstate__ and __setstate__ dunder methods. #173

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Support pickling a PyProgram by implementing __getstate__ and __setstate__ dunder methods. #173

merged 5 commits into from
Mar 21, 2023

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Mar 21, 2023 •
edited
Loading

This allows a PyProgram to be pickled by implementing the __getstate__ and __setstate__ dunder methods.

kalzoo
kalzoo approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that it's still marked as draft, but if that's just because of the placeholder question that work could be deferred to that MR. The to_string(bool) API should go away, forcing us to update this here, so it won't get lost.

quil-py/src/program/mod.rs Show resolved Hide resolved
@MarquessV MarquessV mentioned this pull request Mar 21, 2023
Merged
@MarquessV MarquessV marked this pull request as ready for review March 21, 2023 18:40
@MarquessV MarquessV merged commit ccb803e into 1455-python-support-for-program-and-beyond Mar 21, 2023
@MarquessV MarquessV mentioned this pull request Mar 21, 2023
Closed
@MarquessV MarquessV linked an issue Apr 10, 2023 that may be closed by this pull request
Support pickling of PyProgram #169
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalzoo kalzoo kalzoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pickling of PyProgram
2 participants
@MarquessV @kalzoo