-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with --dolby-vision-rpu copy behavior in QSVEncC 7.73 #222
Comments
Actually, the behaviour you have got without It is strongly recommended to use both The
Overall, both However, there seems to be some bugs and place for improvement as you have reported, I'll look forward to fix or improve them.
Thank you for reporting this,
I think I'll remove limitation for this. |
@rigaya Thank you also for looking into it for improvement, including the incorrect handling of - QSVEncC options list info: Thank you once again for your efforts in considering improvements to QSVEncC! Your commitment to enhancing the tool is highly valued by the community.😊 |
Additional Question: |
I think we already have it on the docs on each paramters that the other option is recommended to be used.
--dolby-vision-rpu copy is basically no more than copying other than the profile conversion. Therefore, adjustments for cropping will be needed manually. (extract → edit → import by |
@rigaya |
I'm quite unsure what adjustments are needed when cropping is done. If what is needed is --crop in dovi_tool, it might be possible to add option to pass "active area offset" value to libdovi used internally in QSVEnc. (libdovi provides C API |
I found this on the dovi tool github And here on doom 9 |
QSVEnc 7.74 will remove limitation of rate control mode, and add option to set active area offsets to 0 for cropping. |
Thank you very much 😊 |
@rigaya I want to ask: Mediainfo original input file: cmd shows:
Mediinfo output file: Why I'm asking is because on the |
I noticed one more thing. When the following settings are used:
The file gets processed even if there is no RPU file in the source. As a result, the output contains Dolby Vision metadata. Would it be possible to implement a check to handle this scenario? |
In any cases I recommend to use
Actually not. QSVEnc have not implemented profile conversion. Please think that only simple stuff is implemented. As written previously, The confusion is that the rpu side also has dolby vision profile information, and the mismatch between mediainfo output and the log is caused by the mismatch between container side information and rpu information. In any case, it is considered as user's responsibility to use As I think this is difficult, the most preferred and expected usage is to simply use
No, As I also think this might not be expected, what I recommend here is also |
Thank you very much for the information. |
Description:
I’ve encountered issues using the
--dolby-vision-rpu copy
feature in QSVEncC version 7.73 when attempting to copy Dolby Vision RPU metadata. The behaviour does not seem to align with the documentation.Expected Behavior:
When using
--dolby-vision-rpu copy
on a Dolby Vision Profile 7 input file:The output should automatically convert to Dolby Vision Profile 8, as described in version 7.71 using libdovi.
MediaInfo should reflect Dolby Vision Profile 8 information without additional options.
Observed Behavior:
Without specifying --dolby-vision-profile:
The output only includes HDR10 info, not Dolby Vision.
MediaInfo shows:
Adding --dolby-vision-profile 8.1:
Dolby Vision Profile 8.1 metadata is correctly included.
MediaInfo reflects:
Specifying an invalid profile (e.g., 7):
The output shows:
MediaInfo reflects:
CQP Mode with --dolby-vision-profile 8.1:
Errors with:
Please use Bitrate Mode - CBR/Bitrate Mode - VBR/Bitrate Mode - AVBR/VCM (Video Conference Mode)/Quality VBR bitrate mode for dolby vision output.
However, specifying Profile 7 works without error (even though Profile 7 shouldn’t be valid here).
System Details:
QSVEnc Version: QSVEncC (x64) 7.73 (r3500) by rigaya, Nov 12 2024
OS: Windows 11 x64 (22631) [UTF-8]
CPU Info: 13th Gen Intel Core i5-13600 [4.89GHz] (6P+8E,14C/20T)
GPU Info: Intel Arc A770 Graphics (512EU) 300-2400MHz (32.0.101.6130)
Media SDK: QuickSyncVideo (hardware encoder) FF, 1st GPU(d), API v2.13
Steps to Reproduce:
Use a Dolby Vision Profile 7 input file.
Run QSVEnc with the following commands:
Check the output file with MediaInfo.
Add
--dolby-vision-profile 8.1
and observe changes.Test with invalid profiles (e.g., --dolby-vision-profile 7) and note the behaviour.
Attempt CQP mode with Profile 8.1 and observe the error.
Request for Guidance:
Is the observed behavior a bug or an intentional change in version 7.73?
If intentional, what is the correct way to copy Dolby Vision RPU while preserving Dolby Vision Profile 8 metadata?
Can support for CQP mode with Dolby Vision Profile 8.1 be clarified or implemented?
Thank you so much for your help.
The text was updated successfully, but these errors were encountered: