Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdr2sdr colorprim ignored #134

Closed
holmy88 opened this issue May 6, 2023 · 5 comments
Closed

hdr2sdr colorprim ignored #134

holmy88 opened this issue May 6, 2023 · 5 comments

Comments

@holmy88
Copy link

holmy88 commented May 6, 2023

colorprim setting is being ignored when using hdr2sdr and is always doing bt2020:bt709 when I'm trying to use st432-1:bt709. This was fixed up in nvencc last year if that solution can be duplicated.

@rigaya
Copy link
Owner

rigaya commented May 10, 2023

Thank you for letting me know the issue, QSVEnc 7.39 has ported fix from NVEncC.

@holmy88
Copy link
Author

holmy88 commented May 13, 2023

Just tried it, colorprim setting still being ignored and doing bt2020:bt709 instead. My full command below

"C:\Temp\bin\encc\qsvencc64.exe" --avhw -i "C:\Temp\Thread1\video_in.mkv" --avsync forcecfr --crop 0,276,0,276 --codec hevc --output-depth 10 --quality 1 --qvbr 17800k --qvbr-quality 20 --fallback-rc --max-bitrate 19580k --vbv-bufsize 17800k --la-depth 100 --gop-len 50 --hyper-mode adaptive --i-adapt --b-adapt --adapt-ref --adapt-ltr --b-pyramid --tskip --sao none --vpp-colorspace hdr2sdr=reinhard,source_peak=10000,peak=4000,desat_strength=1,colorprim=st432-1:bt709,matrix=bt2020nc:bt709,transfer=smpte2084:bt709 --colormatrix bt709 --colorprim bt709 --transfer bt709 --colorrange limited -o "C:\Temp\Thread1\video_out.mkv"

image

rigaya added a commit that referenced this issue May 14, 2023
@rigaya
Copy link
Owner

rigaya commented May 14, 2023

The problem was the handling of colorprim when using hdr2sdr. QSVEnc 7.40 should have fixed this issue.

@holmy88
Copy link
Author

holmy88 commented May 15, 2023

Just tested with my script, I can confirm it is now working. Thank you.

@rigaya
Copy link
Owner

rigaya commented Jul 23, 2024

I'll close this issue, as the problem should have been fixed.

@rigaya rigaya closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants