Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot:ModalDialog control #1708

Closed
Luko248 opened this issue Oct 6, 2023 · 0 comments · Fixed by #1776
Closed

dot:ModalDialog control #1708

Luko248 opened this issue Oct 6, 2023 · 0 comments · Fixed by #1776
Labels
good first issue

Comments

@Luko248
Copy link

Luko248 commented Oct 6, 2023

There is a native HTML dialog component, which would be useful to wrap into a dot:ModalDialog control. The documentation for the dialog component is at this link: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog
exyi added a commit that referenced this issue Feb 18, 2024
@exyi
New dot:ModalDialog control, wrapper for <dialog>
22d6698 
The control closes or shows the modal based on an Open property.
The modal is always shown using the .showModal() method,
non-modal dialog is already accessible by binding the open
attribute of dialog HTML element.
The Open property may either be a boolean or a nullable object,
the dialog is shown if the value isn't false nor null.

On close event, false or null is written back into the Open property.
Otherwise, we'd quickly have inconsistent viewModel whenever
the user closes the dialog with ESC.
Close event is also provided for explicit event handling.

We also optionaly provide a helper for implementing
"close after backdrop click" functionality. It is not supported by
the dialog element natively and could not be otherwise
implemented without writing custom JS.
It is enabled by setting CloseOnBackdropClick=true

Resolves  #1708
@exyi exyi mentioned this issue Feb 18, 2024
Merged
exyi added a commit that referenced this issue Feb 26, 2024
@exyi
New dot:ModalDialog control, wrapper for <dialog>
259476a 
The control closes or shows the modal based on an Open property.
The modal is always shown using the .showModal() method,
non-modal dialog is already accessible by binding the open
attribute of dialog HTML element.
The Open property may either be a boolean or a nullable object,
the dialog is shown if the value isn't false nor null.

On close event, false or null is written back into the Open property.
Otherwise, we'd quickly have inconsistent viewModel whenever
the user closes the dialog with ESC.
Close event is also provided for explicit event handling.

We also optionaly provide a helper for implementing
"close after backdrop click" functionality. It is not supported by
the dialog element natively and could not be otherwise
implemented without writing custom JS.
It is enabled by setting CloseOnBackdropClick=true

Resolves  #1708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New dot:ModalDialog control, wrapper for <dialog> riganti/dotvvm
2 participants
@exyi @Luko248