feat: use recommended unicorn config #2502
Conversation
| 'unicorn/no-for-loop': 'error', | ||
| 'unicorn/no-hex-escape': 'error', | ||
| 'unicorn/no-instanceof-builtins': 'error', | ||
| 'unicorn/no-keyword-prefix': 'off', |
There was a problem hiding this comment.
this is off in the recommended config as well
| // This is covered by @typescript-eslint/no-deprecated | ||
| 'unicorn/no-new-buffer': 'off', | ||
| 'unicorn/no-null': 'off', | ||
| // Unnecessary with TypeScript. | ||
| 'unicorn/no-object-as-default-parameter': 'off', | ||
| 'unicorn/no-process-exit': 'off', |
There was a problem hiding this comment.
this looks useful to me, and there's not that many usages across our codebases, so I think it's fine if it's disabled on a case-by-case basis
| // This is covered by @typescript-eslint/no-deprecated | ||
| 'unicorn/no-new-buffer': 'off', | ||
| 'unicorn/no-null': 'off', | ||
| // Unnecessary with TypeScript. | ||
| 'unicorn/no-object-as-default-parameter': 'off', | ||
| 'unicorn/no-process-exit': 'off', | ||
| // Do not use classes in the first place. | ||
| 'unicorn/no-static-only-class': 'off', |
There was a problem hiding this comment.
this also seems like it would be useful if for some reason the codebase allows classes, so removed this override
| 'unicorn/no-unreadable-array-destructuring': 'off', | ||
| 'unicorn/no-unused-properties': 'off', |
There was a problem hiding this comment.
this is also off in the recommended config
| 'unicorn/prefer-date-now': 'error', | ||
| 'unicorn/prefer-default-parameters': 'error', | ||
| // Manual DOM manipulation is discouraged. | ||
| 'unicorn/prefer-dom-node-append': 'off', |
There was a problem hiding this comment.
not sure why turn these off, like if we do manipulate the DOM for some reason, why not have these suggestions
| 'unicorn/prefer-number-properties': 'error', | ||
| 'unicorn/prefer-object-from-entries': 'error', | ||
| // Not supported yet. | ||
| 'unicorn/prefer-object-has-own': 'off', |
There was a problem hiding this comment.
this is now part of ESLint rules, not unicorn
| 'unicorn/require-array-join-separator': 'error', | ||
| 'unicorn/require-number-to-fixed-digits-argument': 'error', | ||
| // No good use cases yet. | ||
| 'unicorn/string-content': 'off', |
There was a problem hiding this comment.
also off in the recommended config
| // No good use cases yet. | ||
| 'unicorn/string-content': 'off', | ||
| 'unicorn/throw-new-error': 'error', | ||
| 'unicorn/switch-case-braces': ['error', 'avoid'], |
There was a problem hiding this comment.
the default is always require braces, and from looking at our codebases it seems like it's not how we usually write it. changed to avoid for this reason, see docs for details
|
Nice!! |
To get the most out of the ESLint plugins we include, it's better if we extend recommended rules so that we get useful updates whenever they're extended. I reviewed our rule overrides to check which have the same configuration in the recommended config and removed these, left a few that are configured differently.