-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FreshPageModelMapper.cs #70
Conversation
yes please! :) just stumbled upon that myself. |
@rid00z even if you don't merge, be so kind to update the documentation accordingly as it is really ambiguous saying "Now we can use both the ViewModel naming conventions." |
This would be a breaking change for other apps, it sounds great but can it be done in a non breaking change? |
Hi, absolutely it may or not may breaking. It´s a bug and if someone use this method as is is he need to fix them. I am not a friend of encapsule so simple bugs in a workaround. If you realy to avoid breaking a possible solution can be searching the assemblies if a class will be exists before replacing the name. Can Type.GetType() do this work ? |
Technically it's not a bug it's a preference. Many people already rely on this default, if you change it then it will break for many people. How do we accommodate those people? |
You are the maintainer its your choice ;) I think its a simple bug and a commit message and release note should be enough for these peoples to change the code or stay on old version. |
@rid00z https://gist.github.com/blackice2999/44a3f5c3fe2de695f5cc371234dc75ee |
my take: #71 |
I think it make sense to discuss this issue on a single place: #72 |
Hi,
i think its useful if the FreshPageModelMapper returns "View" instead of "Page" if the ViewModel Name ist "ViewModel" instead of "PageModel".
What do you think about it?