Use Tor's ADD_ONION command when available #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the HiddenService class API to handle services that have no filesystem representation.
For versions of Tor that support it, use ADD_ONION instead of SETCONF to configure hidden services.
For Tor >= 0.2.7, we can use ADD_ONION to configure hidden services, so private keys no longer need to be in separate files on disk. When possible, stop using those files and store keys only in our configuration file. Existing profiles will copy their keys into the configuration file, but the old files will not be removed yet. Older versions of Tor remain supported as well, and will always use the filesystem.
This was referenced Mar 17, 2016
|
What kind of tests do you want to see here to merge this code? |
| out += " NEW:RSA1024"; | ||
| } | ||
|
|
||
| foreach (const HiddenService::Target &target, m_service->targets()) { |
There was a problem hiding this comment.
not something you have to change now, but in the future you may want to look into range-for (and qAsConst), it avoids copies of data & leads to smaller binary size.
|
👍 |
special
added a commit
that referenced
this pull request
Mar 21, 2016
Use Tor's ADD_ONION command when available
|
Works for me on SubgraphOS now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Tor >= 0.2.7, start using the ADD_ONION control command instead of SETCONF to configure hidden services, and store the private keys in our configuration file instead of as separate files on the filesystem.
Older versions of Tor remain supported, and the behavior will not change. There is an edge case where a profile is created with a new version of Tor and later downgraded - this is not supported. Don't do that.
Existing profiles will copy their keys into the configuration and stop using the files on disk, but those files will not be removed yet to help avoid any risk of data loss. They will be removed later, likely when we enable profile encryption.
Fixes #227