Skip to content

Commit

Permalink
ci: don't do retries on tests in CI on master, release branches
Browse files Browse the repository at this point in the history
First of all, test retries don't even have the correct behavior: cockroachdb#103042
This means that a successfully-retried test tramples the logs of
previously-failed tests, which is very confusing and erases your ability
to debug the test.

Also, we are focusing on quality and wiping out flaky and skipped tests.
This to me suggests we should not be retrying tests to let already-flaky
tests through. Rather, we should be surfacing real failures immediately.

For both of these reasons I turn off test retries for unit tests on
`master` and release branches.

We keep it for `staging` so `bors` is unaffected.

Epic: none
Release note: None
  • Loading branch information
rickystewart committed Jul 6, 2023
1 parent 818aec8 commit b9f4159
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build/teamcity/cockroach/ci/tests/unit_tests_ccl_impl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ bazel build //pkg/cmd/bazci --config=ci

EXTRA_PARAMS=""

if tc_release_branch || tc_bors_branch; then
if tc_bors_branch; then
# enable up to 1 retry (2 attempts, worst-case) per test executable to report flakes but only on release branches and staging.
EXTRA_PARAMS=" --flaky_test_attempts=2"
fi
Expand Down
2 changes: 1 addition & 1 deletion build/teamcity/cockroach/ci/tests/unit_tests_impl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ bazel build //pkg/cmd/bazci --config=ci

EXTRA_PARAMS=""

if tc_release_branch || tc_bors_branch; then
if tc_bors_branch; then
# enable up to 1 retry (2 attempts, worst-case) per test executable to report flakes but only on release branches and staging.
EXTRA_PARAMS=" --flaky_test_attempts=2"
fi
Expand Down

0 comments on commit b9f4159

Please sign in to comment.