Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue 199 by ignoring items/lines that are completely invalid when parsing a signature file #203

Closed
wants to merge 1 commit into from

Conversation

kyp44
Copy link

@kyp44 kyp44 commented Oct 27, 2022

Fixes issue 199.

Since the generation of the signature file is done by directly writing the output of the apt backend command, it was easier to fix this when parsing the signature file by putting the line splitting in a try block and simple ignoring that line/item if that fails.

In my opinion this isn't even an issue that we should have to fix in apt-offline. It should be the case that apt and apt-get do not output this advertisement when you enable the highest quiet level like apt-offline does. If this is fixed in those tools later, this apt-offline fix will just have no effect but will not cause any problems. This fix should also protect against any future odd lines that they decide to have apt or apt-get print out even in quiet mode.

@kyp44 kyp44 closed this by deleting the head repository Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: too many values to unpack
1 participant