feat: improve 'eval_robustness' utility #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the 'eval_robustness' utility so that users no longer need to modify their environments to use it with this utility. The disturbers are now implemented as [gymnasium wrappers](https://gymnasium.farama.org/api/wrappers/). Because of this, they can be used with any [gymnasium environment](https://gymnasium.farama.org/). If you want to add a new disturber, you only have to ensure that it is a Python class that inherits from the [gym.Wrapper](https://github.com/Farama-Foundation/Gymnasium/blob/ba348890af369dad6e6093665fd4e54d8d4b4824/gymnasium/core.py#L246-L249) class.
rickstaa
added a commit
to rickstaa/stable-gym
that referenced
this pull request
Aug 2, 2023
This commit removes the disturber superclass now that this functionality was moved to the https://github.com/rickstaa/stable-learning-control package (see rickstaa/stable-learning-control#313).
rickstaa
added a commit
to rickstaa/stable-gym
that referenced
this pull request
Aug 2, 2023
This commit removes the disturber superclass now that this functionality was moved to the https://github.com/rickstaa/stable-learning-control package (see rickstaa/stable-learning-control#313).
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the 'eval_robustness' utility so that users no longer need to modify their environments to use it with this utility. The disturbers are now implemented as gymnasium wrappers. Because of this, they can be used with any gymnasium environment. If you want to add a new disturber, you only have to ensure that it is a Python class that inherits from the gym.Wrapper class.